DOC: Add docs for DataFrameGroupBy.fillna and SeriesGroupBy.fillna #48771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Enhancement
Docs
Groupby
Missing-data
rhshadrach
commented
Sep 25, 2022
| @@ -6730,9 +6730,9 @@ def fillna( | |||
| each index (for a Series) or column (for a DataFrame). Values not | |||
| in the dict/Series/DataFrame will not be filled. This value cannot | |||
| be a list. | |||
| method : {{'backfill', 'bfill', 'pad', 'ffill', None}}, default None | |||
There was a problem hiding this comment.
pad is deprecated, so I removed from the fillna docstrings. backfill is deprecated in groupby but not DataFrame or Series. I'll look into this for a followup.
Comment on lines
+781
to
+782
| inplace : bool, default False | ||
| Broken. Do not set to True. |
There was a problem hiding this comment.
For both DataFrameGroupBy and SeriesGroupBy, using inplace=True doesn't modify the source and returns an empty DataFrame or a Series filled with None respectively. I plan to deprecate this in a followup.
mroeschke
approved these changes
Sep 26, 2022
|
Thanks @rhshadrach |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…andas-dev#48771) * DOC: Add docs for DataFrameGroupBy.fillna and SeriesGroupBy.fillna * fixup
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.