-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
added sytle in stylesheet for <blockquote> #48770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for working on this @Himanshuwagh. Would be good if you can share a screenshot of how this looks in both desktop and mobile, so people can have feedback on that. Also, if it makes sense, would be good to keep consistency on |
@datapythonista can you help as to how to check changes on mobile version. |
If you're using Brave or Chrome (and probably other browsers), you can simply right click anywhere in the screen, select If you also include the nonrmal paragraphs around the blokquote in the screenshot that would be better, it'll make it clearer how things look like. Thanks for all the work on this @Himanshuwagh |
@datapythonista Thanks for help. |
Thanks @Himanshuwagh this is great. I wonder if it'd look better if we remove the left margin, leave the line aligned with the text, and increase a bit the padding between the left line and the text. What do you think? No big deal, probably just a personal preference, but having both padding and margin looks a bit strange to me. Feel free to disagree if you think it's ok like it is now. Thanks! |
Yes, @datapythonista this looks good to me. Let me know if you suggested the same. |
Yes, your screenshot is what I'd do. I'd probably have the same padding in the top and bottom of the gray box too. Having the padding much smaller in the top loos a bit strange to me. |
@datapythonista updated sir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, thanks @Himanshuwagh, nice work!
Thanks @datapythonista for helping throughout. Next steps ? merge would taken care of ? |
Someone else from the team will double check and merge |
Thanks @Himanshuwagh |
…ockquote>) (#49102) Backport PR #48770: added sytle in stylesheet for <blockquote> Co-authored-by: Himanshu Wagh <[email protected]>
* added sytle in stylesheet for <blockquote> * Update pandas.css * Update pandas.css * Update pandas.css * Update pandas.css Co-authored-by: himanshu_wagh <[email protected]>
Closes #48758
added styles for stylesheets for
<blockquote>
tag- screenshot of desktop
- screenshot of mobile