WARN: Catch warning in tests #48753
WARN: Catch warning in tests #48753
Conversation
| @@ -204,7 +206,11 @@ def test_scatter_with_c_column_name_with_colors(self, cmap, kw): | |||
| columns=["length", "width"], | |||
| ) | |||
| df["species"] = ["r", "r", "g", "g", "b"] | |||
| ax = df.plot.scatter(x=0, y=1, cmap=cmap, **{kw: "species"}) | |||
| if mpl_ge_3_6_0() and cmap is not None: | |||
| with tm.assert_produces_warning(UserWarning, check_stacklevel=False): | |||
There was a problem hiding this comment.
does this indicate that we are doing something wrong/outdated?
There was a problem hiding this comment.
@MarcoGorelli looks like you raised and addressed this issue in #34344
Do you remember if passing cmap in plot.scatter was necessary to test this behavior?
There was a problem hiding this comment.
FWIW: I think this is a new warning in mpl 3.6 so plot.scatter may have been doing something "wrong" before?
There was a problem hiding this comment.
It was silently ignored before. They added stricter checks in a few places. If we want to check that the colormap is not applied, then we have to check for the user warning
There was a problem hiding this comment.
i have some recollection of this issue/PR, I'll take a look tomorrow
mroeschke
added
Visualization
There was a problem hiding this comment.
Looks good to me
Not overly keen on if-then inside tests, slight preference to split the test into two:
test_scatter_with_c_column_name_with_colors_no_cmaptest_scatter_with_c_column_name_with_colors_with_cmap
and also to add a comment that the warning comes from matplotlib, so it's fine to not check the stacklevel
Not blockers though
| @@ -15,6 +15,8 @@ | |||
| _check_plot_works, | |||
| ) | |||
|
|
|||
| from pandas.plotting._matplotlib.compat import mpl_ge_3_6_0 | |||
There was a problem hiding this comment.
I think this needs to be imported in the test
|
I'd prefer keeping it as one test, this makes comparing easier. |
|
Thanks @phofl |
* WARN: Catch warning in tests * Move import
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @mroeschke