Skip to content

BUG: AttributeError: 'function' object has no attribute 'currentframe' #48736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 26, 2022
Merged

BUG: AttributeError: 'function' object has no attribute 'currentframe' #48736

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b4e97f7
sqlalchemy.inspect shouldnt shadow builtin inspect
Sep 23, 2022
c59c8c2
:label:
Sep 23, 2022
8d8da1d
reword in terms of to_sql
Sep 24, 2022
cf671ec
Merge remote-tracking branch 'upstream/main' into case-insensitive-ta…
Sep 24, 2022
df5024c
Merge remote-tracking branch 'upstream/main' into case-insensitive-ta…
Sep 26, 2022
b780065
import sqlalchemy.inspect as sqlalchemy_inspect
Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.5.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Fixed regressions
- Fixed Regression in :meth:`DataFrame.loc` when setting values as a :class:`DataFrame` with all ``True`` indexer (:issue:`48701`)
- Regression in :func:`.read_csv` causing an ``EmptyDataError`` when using an UTF-8 file handle that was already read from (:issue:`48646`)
- Fixed performance regression in :func:`factorize` when ``na_sentinel`` is not ``None`` and ``sort=False`` (:issue:`48620`)
-
- Fixed regression in :meth:`SQLDatabase.check_case_sensitive` causing an ``AttributeError`` when table name can't be found (:issue:`48733`)

.. ---------------------------------------------------------------------------

Expand Down
8 changes: 4 additions & 4 deletions pandas/io/sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1645,10 +1645,10 @@ def check_case_sensitive(
if not name.isdigit() and not name.islower():
# check for potentially case sensitivity issues (GH7815)
# Only check when name is not a number and name is not lower case
from sqlalchemy import inspect
sqlalchemy = import_optional_dependency("sqlalchemy", errors="ignore")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a need to use import_optional_dependency here? (I would assume that if you get at this point without having sqlalchemy installed, you already got an error about that earlier? eg the init of this class also imports from sqlalchemy)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, no need, might as well just import with an alias


with self.connectable.connect() as conn:
insp = inspect(conn)
insp = sqlalchemy.inspect(conn)
table_names = insp.get_table_names(schema=schema or self.meta.schema)
if name not in table_names:
msg = (
Expand Down Expand Up @@ -1757,9 +1757,9 @@ def tables(self):
return self.meta.tables

def has_table(self, name: str, schema: str | None = None):
from sqlalchemy import inspect
sqlalchemy = import_optional_dependency("sqlalchemy", errors="ignore")

insp = inspect(self.connectable)
insp = sqlalchemy.inspect(self.connectable)
return insp.has_table(name, schema or self.meta.schema)

def get_table(self, table_name: str, schema: str | None = None) -> Table:
Expand Down
15 changes: 11 additions & 4 deletions pandas/tests/io/test_sql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,10 +1357,17 @@ def test_not_reflect_all_tables(self):

def test_warning_case_insensitive_table_name(self, test_frame1):
# see gh-7815
#
# We can't test that this warning is triggered, a the database
# configuration would have to be altered. But here we test that
# the warning is certainly NOT triggered in a normal case.
Comment on lines -1361 to -1363
Copy link
Member Author

@MarcoGorelli MarcoGorelli Sep 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jorisvandenbossche since there is check_case_sensitive, I think it is possible to test the warning without altering the database?

This text was added in https://github.com/pandas-dev/pandas/pull/8180/files

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's from a long time ago ;)

Yes, we can certainly test the helper method to raise the warning (as you did now), that's useful to add, but strictly speaking that's still not a 100% guarantee that it will work in practice, as it doesn't ensure we call this helper method (we could accidentally remove that in a refactor).
(maybe we could also mock the helper to ensure it's being called from to_sql .. but I think the current test is also good enough)

with tm.assert_produces_warning(
UserWarning,
match=(
r"The provided table name 'TABLE1' is not found exactly as such in "
r"the database after writing the table, possibly due to case "
r"sensitivity issues. Consider using lower case table names."
),
):
sql.SQLDatabase(self.conn).check_case_sensitive("TABLE1", "")

# Test that the warning is certainly NOT triggered in a normal case.
with tm.assert_produces_warning(None):
test_frame1.to_sql("CaseSensitive", self.conn)

Expand Down