BUG: Restrict Timestamp(nanosecond=...) to [0, 999] #48691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Deprecate
pandas/_libs/tslibs/timestamps.pyx
Outdated
| if nanosecond is None: | ||
| nanosecond = 0 | ||
| elif not (999 >= nanosecond >= 0): | ||
| warnings.warn( |
There was a problem hiding this comment.
could we just fix these now? The -1 case at least looks very broken
There was a problem hiding this comment.
Hmm probably could be okay for 2.0 API change. Technically 999 < nanosecond < int32_max works okay, but sure can fix it in one go.
mroeschke
changed the title
phofl
approved these changes
Sep 29, 2022
|
thx @mroeschke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.6.0.rstfile if fixing a bug or adding a new feature.