Skip to content

REGR: sort_value can not sort levels with non nas and nans #48626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

REGR: sort_value can not sort levels with non nas and nans #48626

wants to merge 1 commit into from

Conversation

phofl
Copy link
Member

@phofl phofl commented Sep 18, 2022

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

cc @lukemanley

open for suggestions if there is a more efficient way, but this raises right now while it did not before

@phofl phofl added Regression Functionality that used to work in a prior pandas version MultiIndex labels Sep 18, 2022
@phofl phofl added this to the 1.6 milestone Sep 18, 2022
@lukemanley
Copy link
Member

#48495 handles this case (I just tested it). If we can merge #48495 I don't think we need this.

@phofl
Copy link
Member Author

phofl commented Sep 18, 2022

Can you add this specific test too?

@lukemanley
Copy link
Member

yep, added.

@phofl
Copy link
Member Author

phofl commented Sep 18, 2022

Thx, will keep open till the other is merged.

@phofl phofl mentioned this pull request Sep 19, 2022
Closed
5 tasks
@phofl phofl removed this from the 1.6 milestone Oct 7, 2022
@phofl
Copy link
Member Author

phofl commented Oct 7, 2022

other pr was merged, so this is fixed

@phofl phofl closed this Oct 7, 2022
@phofl phofl deleted the sort_values_regression branch October 23, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
MultiIndex Regression Functionality that used to work in a prior pandas version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @lukemanley