Revised the doc-string for _app_template to bring in line with curren… #48613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t aggregate() code, in particular with regard to Named Aggregation. Also fixed text in "See Also" section, where the entries for groupby.transform and aggregate had their text swapped.
mroeschke
reviewed
Sep 19, 2022
Co-authored-by: Matthew Roeschke <[email protected]>
mroeschke
requested changes
Sep 26, 2022
pandas/core/groupby/groupby.py
Outdated
| @@ -529,6 +529,9 @@ class providing the base-class of operations. | |||
| - string function name | |||
| - list of functions and/or function names, e.g. ``[np.sum, 'mean']`` | |||
| - dict of axis labels -> functions, function names or list of such. | |||
| - None, in which case output is determined from ``**kwargs`` using Named Aggregation. In this scenario the output | |||
| has one column for each element in ``**kwargs``. The name of the column is a string of the keyword's variable name. The | |||
There was a problem hiding this comment.
I think from the Ci checks that the line lengths here are too long: https://github.com/pandas-dev/pandas/actions/runs/3102809189/jobs/5025470354
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
@DRudel - do you have any interest in continuing this? If not, okay if I push it over the finish line? |
|
Sorry for dropping this. Life intervened.
Yes, it would be great if you could take it.
Thanks so much!
…On Sun, Nov 13, 2022 at 7:06 AM Richard Shadrach ***@***.***> wrote:
@DRudel <https://github.com/DRudel> - do you have any interest in
continuing this? If not, okay if I push it over the finish line?
—
Reply to this email directly, view it on GitHub
<#48613 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGGJ7MMXXV2ETE2X7YKKPLWID7WVANCNFSM6AAAAAAQPEQGTI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
"A false conclusion, once arrived at and widely accepted is not dislodged
easily, and the less it is understood, the more tenaciously it is held." -
Cantor's Law of Preservation of Ignorance.
|
…-doc-string-for-_agg_template-(GH-pandas-dev#47974)'
mroeschke
approved these changes
Dec 17, 2022
|
Thanks @DRudel and @rhshadrach for finishing this up! |
|
Thanks @DRudel! |
|
Thanks so much for finishing this! Sorry I got tied up.
…On Sat, Dec 17, 2022 at 12:26 PM Richard Shadrach ***@***.***> wrote:
Thanks @DRudel <https://github.com/DRudel>!
—
Reply to this email directly, view it on GitHub
<#48613 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGGJ7NS77H54TQQUFRKANTWNYOZFANCNFSM6AAAAAAQPEQGTI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
"A false conclusion, once arrived at and widely accepted is not dislodged
easily, and the less it is understood, the more tenaciously it is held." -
Cantor's Law of Preservation of Ignorance.
|
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Dec 17, 2022
pandas-dev#48613) * Revised the doc-string for _app_template to bring in line with current aggregate() code, in particular with regard to Named Aggregation. Also fixed text in "See Also" section, where the entries for groupby.transform and aggregate had their text swapped. * Update pandas/core/groupby/groupby.py Co-authored-by: Matthew Roeschke <[email protected]> * fixup * Language tweaks Co-authored-by: Matthew Roeschke <[email protected]> Co-authored-by: MarcoGorelli <> Co-authored-by: Richard Shadrach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revised the doc-string for _app_template to bring in line with current code for aggregate(), in particular regarding the advent of Named Aggregation.
Also fixed text in "See Also" section, where the entries for groupby.transform and aggregate had their text swapped.