-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
PERF: DatetimeIndex constructor from list #48609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
phofl
merged 8 commits into
pandas-dev:main
from
lukemanley:perf-ensure-arraylike-for-datetimelike
Sep 20, 2022
Merged
PERF: DatetimeIndex constructor from list #48609
phofl
merged 8 commits into
pandas-dev:main
from
lukemanley:perf-ensure-arraylike-for-datetimelike
Sep 20, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A general note: I think our rule of thumb regarding benchmarks is: Around 20ms. |
Sorry, I should have remembered. I just updated the asv to reduce the time:
|
Thx, no worries |
…ke-for-datetimelike
mroeschke
reviewed
Sep 19, 2022
mroeschke
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merge when ready @phofl
…ke-for-datetimelike
phofl
approved these changes
Sep 20, 2022
thx @lukemanley |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.6.0.rst
file if fixing a bug or adding a new feature.Improvement comes from avoiding np.ndim on a large list of objects.
ASVs added: