Skip to content

update pd.DataFrame.merge - add typing for how parameter #48513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

update pd.DataFrame.merge - add typing for how parameter #48513

wants to merge 1 commit into from

Conversation

alexcolemandata
Copy link

@alexcolemandata
Copy link
Author

PR for pandas-stubs: pandas-dev/pandas-stubs#289

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, can you add this for join too? Additionally, I think we are typing how internally too, would be great to add this there too

@twoertwein
Copy link
Member

Thx, can you add this for join too? Additionally, I think we are typing how internally too, would be great to add this there too

For DataFrame.join, you probably need MergeHow | Literal["cross"].

Could also use MergeHow in Index.join/_join* (in pandas/core/indexes/base.py) and for the align methods NDFrame/DataFrame/Series.align (in pandas/core/{generic,frame,series}.py)

@mroeschke mroeschke added the Typing type annotations, mypy/pyright type checking label Sep 12, 2022
@phofl
Copy link
Member

phofl commented Sep 12, 2022

MergeHow includes cross already?

@twoertwein
Copy link
Member

MergeHow includes cross already?

You are right :) Forget about my comment :)

@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Oct 13, 2022
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Typing type annotations, mypy/pyright type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: .merge - specify string literals for .merge how keyword
4 participants