WEB: Update Python for Data Analysis book #48491
Conversation
There was a problem hiding this comment.
Looks good. I don't remember exactly, but I think I comverted the image to a gif with custom palette to make it as small as possible last time. I see the new image is 30kb vs the 5kb of the old. Maybe not a big deal, bit we could try to do the same and keep the size of the pandas repo a bit smaller.
|
Sounds reasonable to convert the jpg to gif to reduce size. Not too familiar how to do that so any suggestions? |
|
This is the original 30 kb file:
I'd use this version, it's 12kb:
I can reduce it more, but the new cover has more colors and it's more sensitive than the previous to compression. While probably no big deal, the quality of a smaller version starts to be clearly worse. This is a 8kb image:
|
web/pandas/getting_started.md
Outdated
| <a href="https://amzn.to/2KI5JJw"> | ||
| <img alt="Python for Data Analysis" src="{{ base_url }}/static/img/pydata_book.gif"/> | ||
| <a href="https://amzn.to/3DyLaJc"> | ||
| <img alt="Python for Data Analysis" src="{{ base_url }}/static/img/pydata_book.jpg"/> |
There was a problem hiding this comment.
You need to revert this back to gif
web/pandas/index.html
Outdated
| <a href="https://amzn.to/2KI5JJw"> | ||
| <img class="img-fluid" alt="Python for Data Analysis" src="{{ base_url }}/static/img/pydata_book.gif"/> | ||
| <a href="https://amzn.to/3DyLaJc"> | ||
| <img class="img-fluid" alt="Python for Data Analysis" src="{{ base_url }}/static/img/pydata_book.jpg"/> |
|
Thanks, any thoughts whether we should include this for 1.5? |
There was a problem hiding this comment.
lgtm, thanks @mroeschke
This only affects the website, so I'd merge when ready, independently from 1.5 or any release, which as far as I know are unaffected by the website.
* WEB: Update Python for Data Analysis book * Add small image * Change back to gif
No description provided.