CLN: Refactor groupby._make_wrapper #48400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Sep 6, 2022
mroeschke
reviewed
Sep 6, 2022
| ) | ||
|
|
||
|
|
||
| def test_frame_consistency(request, groupby_func): |
There was a problem hiding this comment.
Side note: Doing something like this for the entire API would be really cool. It would help the ensure when adding/modifying/deprecating methods & their signatures that consistency remains.
mroeschke
reviewed
Sep 7, 2022
mroeschke
approved these changes
Sep 7, 2022
|
Awesome! A lot more straightforward, thanks @rhshadrach |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* CLN: Refactor groupby._make_wrapper * Remove type: ignore * Revert behavior change for corrwith; fix skew and mad * Add docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Currently keeping the docs the same, plan to make groupby-specific docstrings in the future. Note that most of the SeriesGroupBy docs don't make it into the documentation, I've opened #48399. The only change from a user-perspective here should be that Jupyter / IDEs can now get the correct signature (instead of
*args, **kwargs).