CLN: assorted #48385
Merged
CLN: assorted #48385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
reviewed
Sep 4, 2022
| end: Timestamp | None, | ||
| periods: int | None, | ||
| offset: BaseOffset, | ||
| ): |
There was a problem hiding this comment.
Confused why the default value for offset got dropped?
There was a problem hiding this comment.
bc this is never called without passing offset (outside tests, which this changes)
gfyoung
reviewed
Sep 4, 2022
| @@ -1916,7 +1916,7 @@ def _drop_labels_or_levels(self, keys, axis: int = 0): | |||
| # Perform copy upfront and then use inplace operations below. | |||
| # This ensures that we always perform exactly one copy. | |||
| # ``copy`` and/or ``inplace`` options could be added in the future. | |||
| dropped = self.copy() | |||
| dropped = self.copy(deep=False) | |||
There was a problem hiding this comment.
Just trying to be explicit with copy instead of relying on signature defaults?
There was a problem hiding this comment.
this improves perf by avoiding making an actual copy. safe since this method is private
|
|
mypy fixed, just an unrelated timeout remaining |
|
Thanks @jbrockmendel |
3 tasks
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* CLN: assorted * mypy fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.