PERF: avoid unnecessary reordering in MultiIndex._reorder_indexer #48384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
changed the title
datapythonista
approved these changes
Sep 10, 2022
There was a problem hiding this comment.
Thanks @lukemanley, looks good to me.
Can you merge master into your branch? I think CI problems should be fixed now.
mroeschke
reviewed
Sep 12, 2022
| # check if sorting is necessary | ||
| need_sort = False | ||
| for i, k in enumerate(seq): | ||
| if com.is_null_slice(k) or com.is_bool_indexer(k) or is_scalar(k): |
There was a problem hiding this comment.
Do we have unit tests for all these new branches that short circuit?
There was a problem hiding this comment.
I'm pretty there are tests that hit these in one way or another. Regardless, I just added test_get_locs_reordering that explicitly tests the ordering effects of: null slices, bool indexers, scalars, and lists of length 1.
mroeschke
approved these changes
Sep 13, 2022
|
Thanks @lukemanley |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…ndas-dev#48384) * Avoid unnecessary reordering in MultiIndex._reorder_indexer * whatsnew * mypy * cleanup * add multiindex.get_locs reordering tests * fix test Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.6.0.rstfile if fixing a bug or adding a new feature.MultiIndex._reorder_indexercontains logic to determine if indexer reordering is required. This PR expands the logic a bit to identify additional cases where reordering is not necessary.ASVs: