Skip to content

DOC: how to_datetime %S differs from strptime #48376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 3, 2022

Conversation

yadomkar
Copy link
Contributor

@yadomkar yadomkar commented Sep 3, 2022

@pep8speaks
Copy link

pep8speaks commented Sep 3, 2022

Hello @heroesIV! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-09-03 13:25:02 UTC

@yadomkar
Copy link
Contributor Author

yadomkar commented Sep 3, 2022

This is my first PR. Do let me know if any changes are needed. Open to all feedback.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heroesIV , just suggesting a slight rewording

@MarcoGorelli MarcoGorelli added this to the 1.6 milestone Sep 3, 2022
yadomkar and others added 2 commits September 3, 2022 18:54
Co-authored-by: Marco Edward Gorelli <[email protected]>
Co-authored-by: Marco Edward Gorelli <[email protected]>
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@gfyoung gfyoung merged commit 64c8a05 into pandas-dev:main Sep 3, 2022
@gfyoung
Copy link
Member

gfyoung commented Sep 3, 2022

Thanks @heroesIV !

@yadomkar yadomkar deleted the to_datetime_doc_fix branch September 7, 2022 10:51
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
* doc update for pandas-dev#47134

* black and trailing spaces fixed

* rewording_1 pandas-dev#48376

Co-authored-by: Marco Edward Gorelli <[email protected]>

* rewording_2 pandas-dev#48376

Co-authored-by: Marco Edward Gorelli <[email protected]>

Co-authored-by: Marco Edward Gorelli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOC: how to_datetime %S differs from strptime
5 participants