Skip to content

ENH: __pandas_priority__ #48347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 14, 2023
Merged

Conversation

jbrockmendel
Copy link
Member

Will allow dask/modin to address #38946 and modin-project/modin#4646, respectively.

Also can be used to make non-masked EAs defer to masked EAs.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@datapythonista
Copy link
Member

@jbrockmendel I see there is no feedback from others here. But I guess we'll need documentation if we want to merge this. It should also help the discussion, I checked the referred issues, but it's not immediately clear how the new attribute works.

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on this change. I proposed a more detailed version of the documentation, but other than that this looks good, in particular if NumPy is already doing it this way.

@simonjayhawkins
Copy link
Member

@jbrockmendel Would there be a release note needed for this?

@jbrockmendel
Copy link
Member Author

Added a whatsnew, not sure how to make a reference to _extending.pandas_priority

@jbrockmendel
Copy link
Member Author

@jreback suggestions on how to get the whatsnew to point to the appropriate place in the docs?

@jreback
Copy link
Contributor

jreback commented Feb 23, 2023

#@jbrockmendel no idea sorry

@mroeschke
Copy link
Member

Added a whatsnew, not sure how to make a reference to _extending.pandas_priority

:ref:`See the developer guide <extending.pandas_priority>`

@jbrockmendel
Copy link
Member Author

green

@mroeschke mroeschke added this to the 2.1 milestone Mar 7, 2023
@mroeschke mroeschke merged commit fb754d7 into pandas-dev:main Mar 14, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants