BUG: make Series handle dtype='int64' for string array #48333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Dtype Conversions
phofl
requested changes
Sep 6, 2022
There was a problem hiding this comment.
I think this disables to many checks, for example:
x = pd.Series(['300', '2'], dtype='int8')
This one finishes without warning and converts 300 to 44
while
x = pd.Series([300, 2], dtype='int8')
produces a FutureWarning and will raise in the future. I think we should check, if we are causing overflows here too
phofl
reviewed
Sep 6, 2022
Note the comment at the last line: # No known cases that get here
phofl
approved these changes
Sep 7, 2022
|
Please move whatsnew to 1.6.0 |
mroeschke
approved these changes
Sep 12, 2022
|
Thanks @5j9 |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…8333) * make sure conversion is not lossy * add whatsnew and ref issue in test * raise earlier Note the comment at the last line: # No known cases that get here * mv whatsnew entry to 1.6.0.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValueError: values cannot be losslessly cast to int64for integer strings #44923doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.