Skip to content

to_sql: Adding overwrite or ignore behavior for row conflicts #48331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 145 commits into from

Conversation

JustinGuese
Copy link

I do not know how to continue on the PR of LSturtew (#46232), but I would like to continue on this feature, as only tests or docstrings are missing I guess...
Is there some way to credit LSturtew and cvonsteg for most of the work? It would be unfair if only I get credit for just fixing tests or docstrings

…t 88a5a481b

git-subtree-dir: vendor/github.com/V0RT3X4/python_utils
git-subtree-split: 88a5a481b5dbec610e762df862fd69918c1b77d4
git-vendor-name: python_utils
git-vendor-dir: vendor/github.com/V0RT3X4/python_utils
git-vendor-repository: [email protected]:V0RT3X4/python_utils.git
git-vendor-ref: master
git-vendor-name: python_utils
git-vendor-dir: vendor/github.com/V0RT3X4/python_utils
git-vendor-repository: [email protected]:V0RT3X4/python_utils.git
git-vendor-ref: master
…tch function written down for deleting pkeys
…tch function written down for deleting pkeys
…t 88a5a481b

git-subtree-dir: vendor/github.com/V0RT3X4/python_utils
git-subtree-split: 88a5a481b5dbec610e762df862fd69918c1b77d4
git-vendor-name: python_utils
git-vendor-dir: vendor/github.com/V0RT3X4/python_utils
git-vendor-repository: [email protected]:V0RT3X4/python_utils.git
git-vendor-ref: master
git-vendor-name: python_utils
git-vendor-dir: vendor/github.com/V0RT3X4/python_utils
git-vendor-repository: [email protected]:V0RT3X4/python_utils.git
git-vendor-ref: master
@pep8speaks
Copy link

pep8speaks commented Aug 31, 2022

Hello @JustinGuese! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-09-12 13:00:16 UTC

@JustinGuese
Copy link
Author

so as I guessed I think the main reason is that SqlAlchemy has some problems with arm and mac chips (not available)... Any proposals on how to solve it? Can we make a simple exception, if the chipset is arm or mac, just throw a "Not Implemented" error? Probably not the best solution, right?

Alternatively, we could probably swap out SqlAlchemy with the native libraries (MySQL, Postgresql, ...), but that sounds horrible. What are your thoughts?

import sqlalchemy
E   ModuleNotFoundError: No module named 'sqlalchemy'

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, SQL related tests are skipped when Alchemy is not installed

Alchemy is available for arm and Mac

@mroeschke mroeschke added the IO SQL to_sql, read_sql, read_sql_query label Sep 6, 2022
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Oct 13, 2022
@pascaloberle
Copy link

Looking forward to seeing this feature in action! keep up pushing

@pythonlectures
Copy link

Hi @JustinGuese, any update on this? Thanks for your hard work

@JustinGuese
Copy link
Author

yeah we need someone who's good with python tests. at least my last status was that it works, but the tests are failing. any volunteers?

@phofl
Copy link
Member

phofl commented Nov 24, 2022

You are calling functions with invalid keyword arguments. You can step through this locally.

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO SQL to_sql, read_sql, read_sql_query Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants