-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
to_sql: Adding overwrite or ignore behavior for row conflicts #48331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…t 88a5a481b git-subtree-dir: vendor/github.com/V0RT3X4/python_utils git-subtree-split: 88a5a481b5dbec610e762df862fd69918c1b77d4
git-vendor-name: python_utils git-vendor-dir: vendor/github.com/V0RT3X4/python_utils git-vendor-repository: [email protected]:V0RT3X4/python_utils.git git-vendor-ref: master
git-vendor-name: python_utils git-vendor-dir: vendor/github.com/V0RT3X4/python_utils git-vendor-repository: [email protected]:V0RT3X4/python_utils.git git-vendor-ref: master
…tch function written down for deleting pkeys
…tch function written down for deleting pkeys
…hed upsert ignore method
…hed upsert ignore method
…t 88a5a481b git-subtree-dir: vendor/github.com/V0RT3X4/python_utils git-subtree-split: 88a5a481b5dbec610e762df862fd69918c1b77d4
git-vendor-name: python_utils git-vendor-dir: vendor/github.com/V0RT3X4/python_utils git-vendor-repository: [email protected]:V0RT3X4/python_utils.git git-vendor-ref: master
git-vendor-name: python_utils git-vendor-dir: vendor/github.com/V0RT3X4/python_utils git-vendor-repository: [email protected]:V0RT3X4/python_utils.git git-vendor-ref: master
Hello @JustinGuese! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-09-12 13:00:16 UTC |
so as I guessed I think the main reason is that Alternatively, we could probably swap out SqlAlchemy with the native libraries (MySQL, Postgresql, ...), but that sounds horrible. What are your thoughts?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, SQL related tests are skipped when Alchemy is not installed
Alchemy is available for arm and Mac
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Looking forward to seeing this feature in action! keep up pushing |
Hi @JustinGuese, any update on this? Thanks for your hard work |
yeah we need someone who's good with python tests. at least my last status was that it works, but the tests are failing. any volunteers? |
You are calling functions with invalid keyword arguments. You can step through this locally. |
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
.to_sql
#14553, continuation of Adding overwrite or ignore behavior for row conflicts. #46232 and Adding (Insert or update if key exists) option to .to_sql #14553 #29636doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.I do not know how to continue on the PR of LSturtew (#46232), but I would like to continue on this feature, as only tests or docstrings are missing I guess...
Is there some way to credit LSturtew and cvonsteg for most of the work? It would be unfair if only I get credit for just fixing tests or docstrings