BUG: test for empty input construct #48330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ntachukwu
commented
Aug 31, 2022
ntachukwu
commented
- closes API: Specify the behaviour for operating on empty objects #47959
- [Tests added ]
|
Hello @Th3nn3ss! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-08-31 14:40:27 UTC |
1 task
There was a problem hiding this comment.
@Th3nn3ss thanks for the PR!
However, for this specific case, I think there are already some other tests in this file that might cover this. For example, we have test_constructor_dict_of_empty_lists that similarly tests the construction of a dataframe from a dictionary with empty values.
You could maybe also expand the existing test.
|
Great idea. Closing this as all tests for empty inputs are subsequently added to #48327 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.