Skip to content

CI: Check enforcing min botocore due to PY310 six ImportWarning #48297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mroeschke
Copy link
Member

xref #48291 #48278

Checking if botocore's vendored six fixes allow environments to solve and not raise this ImportWarning

@mroeschke mroeschke added CI Continuous Integration Dependencies Required and optional dependencies labels Aug 29, 2022
@mroeschke mroeschke mentioned this pull request Aug 29, 2022
5 tasks
@phofl
Copy link
Member

phofl commented Aug 29, 2022

Ah yeah, if you remove the aiobotocore pin then this causes failures

@mroeschke
Copy link
Member Author

Got it. I think we should move forward with bumping s3fs then.

If we bump s3fs to 2021.08.0 would we still also need the aibotocore pin?

@phofl
Copy link
Member

phofl commented Aug 29, 2022

Don't think so, opened #48299 to find out

@mroeschke mroeschke closed this Aug 29, 2022
@mroeschke mroeschke deleted the ci/check/botocore branch August 29, 2022 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants