Skip to content

TYP: Specify how in dropna #48289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2022
Merged

TYP: Specify how in dropna #48289

merged 1 commit into from
Aug 29, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 28, 2022

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl added the Typing type annotations, mypy/pyright type checking label Aug 28, 2022
twoertwein
twoertwein approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could define Literal["any", "all"] in _typing but looks good to me also as-is

@mroeschke mroeschke added this to the 1.6 milestone Aug 29, 2022
@mroeschke mroeschke merged commit 8955276 into pandas-dev:main Aug 29, 2022
@mroeschke
Copy link
Member

Thanks @phofl. Can follow up with defining any/all in _typing.py

@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
@phofl phofl deleted the typ_dropna branch October 23, 2022 17:39
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@phofl @noatamir
TYP: Specify how in dropna (pandas-dev#48289)
787d045
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @mroeschke @twoertwein