Skip to content

TST: add tests for using .at() with DateTime indexes #48286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 31, 2022
Merged

TST: add tests for using .at() with DateTime indexes #48286

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
888fd82
add tests outlined in GH29709
Aug 27, 2022
df8c5d1
fix styling error caught by github actions
Aug 28, 2022
26a658a
made changes based on suggestions from patrick
Aug 28, 2022
9853f0e
fix pep8 mistakes
Aug 28, 2022
e4488b3
remove usage of to_datetime()
Aug 29, 2022
084597b
fix error in pre-commit checks also move my new test to the bottom of…
Aug 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions pandas/tests/indexing/test_at.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@
CategoricalDtype,
CategoricalIndex,
DataFrame,
DatetimeIndex,
MultiIndex,
Series,
Timestamp,
to_datetime,
)
import pandas._testing as tm

Expand Down Expand Up @@ -97,6 +99,18 @@ def test_at_setitem_categorical_missing(self):

tm.assert_frame_equal(df, expected)

@pytest.mark.parametrize("row", (to_datetime("2019-01-01"), "2019-01-01"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check the whole DataFrame with tm.assert_frame_equal and use Timestamp() instead too?

def test_at_datetime_index(self, row):
df = DataFrame(
data=[[1] * 2] * 2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing data=1 should work here. The dimensions are defined by columns and index in this case

columns=["one", "two"],
index=DatetimeIndex(data=["2019-01-01", "2019-01-02"]),
)

df.at[row, "one"] = 0.5
assert df.at[row, "one"] == 0.5
assert df["one"].dtype == "float64"

def test_at_setitem_multiindex(self):
df = DataFrame(
np.zeros((3, 2), dtype="int64"),
Expand Down