Skip to content

BUG: Fixed inconsistent multiplication behavior #47953 #48275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

srotondo
Copy link
Contributor

@srotondo srotondo commented Aug 26, 2022

@mroeschke mroeschke requested a review from jbrockmendel August 26, 2022 18:36
@mroeschke mroeschke added Numeric Operations Arithmetic, Comparison, and Logical operations Frequency DateOffsets labels Aug 26, 2022
@@ -991,6 +991,7 @@ Datetimelike
- Bug in :meth:`DatetimeIndex.resolution` incorrectly returning "day" instead of "nanosecond" for nanosecond-resolution indexes (:issue:`46903`)
- Bug in :class:`Timestamp` with an integer or float value and ``unit="Y"`` or ``unit="M"`` giving slightly-wrong results (:issue:`47266`)
- Bug in :class:`.DatetimeArray` construction when passed another :class:`.DatetimeArray` and ``freq=None`` incorrectly inferring the freq from the given array (:issue:`47296`)
- Bug in :meth:`RelativeDeltaOffset._apply` which caused inconsistent behavior upon multiplying a :class:`DateOffset` (:issue:`47953`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is internal, can you reference the function that is visible to the user?

@srotondo srotondo requested review from phofl and removed request for jbrockmendel August 31, 2022 00:05
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Oct 7, 2022
@phofl
Copy link
Member

phofl commented Oct 14, 2022

Hi, are you interested in continuing here?

@srotondo
Copy link
Contributor Author

@phofl Yes, sorry I haven't been looking at this recently, I've been very busy recently so I haven't had much time to work on my pull requests.

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frequency DateOffsets Numeric Operations Arithmetic, Comparison, and Logical operations Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: inconsistent behavior of DateOffset
4 participants