Skip to content

ENH: TimedeltaArray add/sub with non-nano #48261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added Timedelta Timedelta data type Non-Nano datetime64/timedelta64 with non-nanosecond resolution labels Aug 26, 2022
@mroeschke
Copy link
Member

mypy.....................................................................Failed
- hook id: mypy
- exit code: 1

pandas/core/arrays/datetimelike.py:1294: error: "DatetimeLikeArrayMixin" has no attribute "_reso"  [attr-defined]
Found 1 error in 1 file (checked 1394 source files)

@mroeschke mroeschke added this to the 1.6 milestone Aug 29, 2022
@mroeschke mroeschke merged commit b8dcd27 into pandas-dev:main Aug 29, 2022
@jbrockmendel jbrockmendel deleted the nano-add_timedelta_arraylike branch August 29, 2022 17:36
@jbrockmendel
Copy link
Member Author

jbrockmendel commented Oct 11, 2022 via email

@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
* ENH: TimedeltaArray add/sub with non-nano

* mypy fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non-Nano datetime64/timedelta64 with non-nanosecond resolution Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants