-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Series repr with pyarrow date32 type #48258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pandas/tests/dtypes/test_common.py
Outdated
def kind(self) -> str: | ||
return "M" | ||
|
||
assert not com.is_datetime64tz_dtype(NotTZDtype()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could also check needs_i8_conversion here
@jbrockmendel don't know if you've ever hit this while working on https://github.com/pandas-dev/pandas/runs/8027023184?check_suite_focus=true
|
i dont think ive seen that, no. is it flaky? |
[finger slipped on the wrong button] |
I don't think so since it appears on some specific builds. I've tried installing those environments on my laptop but can't replicating them. I'll keep poking around. I suspect it has to do with some statefulness. |
Noting if worked on the future: Disabling the pyarrow timedelta types in the tests 21d152c fixed the seemingly unrelated timedelta errors in #48258 (comment), so there may be some odd interaction between then for pyarrow version 5, 6, 7 |
May revisit this later, but since the original issue has been address by another PR, closing |
doc/source/whatsnew/v1.5.0.rst
file if fixing a bug or adding a new feature.