Skip to content

PERF: #48212 Cache the results of get_block_type (1.1.x) #48213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Code0x58
Copy link

@Code0x58 Code0x58 commented Aug 23, 2022

This gave a ~5% performance boost. It looks like things started to slow down in this area after 0.19.2 with more costly type checking.

As mentioned on #48212, I'm upgrading a large codebase and 1.1.x is the limit I can get to without significant changes (upgrading of codebase, libraries, and environments/machines), so this is a great stepping stone. I'd appreciate if this would get accepted as a patch release for it, I'm happy to go through the other 1.x branches to apply the change once a pattern is confirmed.

It looks like the automated CI run doesn't like trying to run on/for 1.1.x, so I'll have a run when I swap machines, but imagine I'll have to make a branch based on master sooner rather than later to get confidence from CI.

This gave a ~5% performance boost. It looks like things started to slow down in this area after 0.19.2 with more costly type checking.
@Code0x58 Code0x58 changed the title PERF: #48212 Cache the results of get_block_type PERF: #48212 Cache the results of get_block_type (1.1.x) Aug 23, 2022
@phofl
Copy link
Member

phofl commented Aug 23, 2022

Hi, thanks for looking into this.

We do not backport anything to our old branches except the newest released branch. This is currently 1.4.x

Please always submit the prs to main. This is necessary to see that everything passes before we backport some changes. That said, in general we do not backport performance improvements if there is not a good reason for it (large performance decrease that can be isolated really well)

@phofl phofl closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants