-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TYP: Autotyping #48191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
TYP: Autotyping #48191
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0794249
annotate-magics
twoertwein 625490b
annotate-imprecise-magics
twoertwein 087a648
none-return
twoertwein 1fa78b5
scalar-return
twoertwein cf79b24
pyi files
twoertwein 6a1c70f
ignore vendored file
twoertwein 1e40b2b
manual changes
twoertwein cb4ade4
ignore pyright in pickle_compat (these errors would be legit if the c…
twoertwein 082a9b4
Merge branch 'main' into autotyping
twoertwein 16ce425
run autotyping in pre-commit
twoertwein ce0fed8
remove final and expand safe (and add annotate-imprecise-magics)
twoertwein 45e254d
Merge remote-tracking branch 'upstream/main' into autotyping
twoertwein 531bba0
Merge branch 'main' into autotyping
twoertwein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# String that LibCST should look for in code which indicates that the | ||
# module is generated code. | ||
generated_code_marker: '@generated' | ||
# Command line and arguments for invoking a code formatter. Anything | ||
# specified here must be capable of taking code via stdin and returning | ||
# formatted code via stdout. | ||
formatter: ['black', '-'] | ||
# List of regex patterns which LibCST will evaluate against filenames to | ||
# determine if the module should be touched. | ||
blacklist_patterns: [] | ||
# List of modules that contain codemods inside of them. | ||
modules: | ||
- 'libcst.codemod.commands' | ||
- 'autotyping' | ||
# Absolute or relative path of the repository root, used for providing | ||
# full-repo metadata. Relative paths should be specified with this file | ||
# location as the base. | ||
repo_root: '.' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I would slightly prefer
--safe
to be expanded into the actual flags it enables (unless there's not a way to enable all the transformations at once) so it's more obvious what autotyping occurs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, will change that.
Is it okay to add the
.libcst.codemod.yaml
? It is needed. If we don't want to clutter the main folder, I could createscripts/run_autotyping.py
and create this file only temporarily.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sure that would be okay!