Skip to content

ENH: consistency of input args for boundaries for resample #48187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

ENH: consistency of input args for boundaries for resample #48187

wants to merge 6 commits into from

Conversation

weikhor
Copy link
Contributor

@weikhor weikhor commented Aug 21, 2022

@weikhor weikhor changed the title ENH: consistency of input args for boundaries for resample ENH: consistency of input args for boundaries for resample Aug 21, 2022
mroeschke
mroeschke requested changes Aug 21, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cannot be directly changed; there would need to be a deprecation for closed first.

Additionally, the issue needs more discussion before moving forward. We recently reverted a similar change due to not enough buy-in from others.

@weikhor
Copy link
Contributor Author

weikhor commented Aug 21, 2022

ok I close this PR Thank

@weikhor weikhor closed this Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: consistency of input args for boundaries
2 participants
@weikhor @mroeschke