Skip to content

BUG: DataFrame.select_dtypes(include=number) still included BooleanDtype #48169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke commented Aug 19, 2022

@mroeschke mroeschke added Dtype Conversions Unexpected or buggy dtype conversions DataFrame DataFrame data structure labels Aug 19, 2022
@mroeschke mroeschke added this to the 1.4.4 milestone Aug 19, 2022
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

We might need to reconsider what's the goal of this _is_numeric property, and whether that should be True for Boolean. But that's beyond the scope of a bug fix.

@jorisvandenbossche jorisvandenbossche merged commit 30efa5f into pandas-dev:main Aug 20, 2022
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 20, 2022
phofl pushed a commit that referenced this pull request Aug 20, 2022
…ude=number) still included BooleanDtype) (#48174)

Backport PR #48169: BUG: DataFrame.select_dtypes(include=number) still included BooleanDtype

Co-authored-by: Matthew Roeschke <[email protected]>
@mroeschke mroeschke deleted the bug/select_dtype_boolean branch August 20, 2022 18:39
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DataFrame DataFrame data structure Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: DataFrame.select_dtypes(include='number') includes BooleanDtype columns
2 participants