BUG/REGR: Fix subset for DataFrameGroupBy.value_counts #48164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Groupby
Algos
phofl
reviewed
Aug 22, 2022
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 23, 2022
…By.value_counts
phofl
pushed a commit
that referenced
this pull request
Aug 23, 2022
…eGroupBy.value_counts) (#48204) Backport PR #48164: BUG/REGR: Fix subset for DataFrameGroupBy.value_counts Co-authored-by: Matthew Roeschke <[email protected]>
| @@ -37,6 +37,7 @@ Bug fixes | |||
| ~~~~~~~~~ | |||
| - The :class:`errors.FutureWarning` raised when passing arguments (other than ``filepath_or_buffer``) as positional in :func:`read_csv` is now raised at the correct stacklevel (:issue:`47385`) | |||
| - Bug in :meth:`DataFrame.to_sql` when ``method`` was a ``callable`` that did not return an ``int`` and would raise a ``TypeError`` (:issue:`46891`) | |||
| - Bug in :meth:`DataFrameGroupBy.value_counts` where ``subset`` had no effect (:issue:`44267`) | |||
There was a problem hiding this comment.
Thanks @simonjayhawkins! Sounds good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v1.4.4.rstfile if fixing a bug or adding a new feature.