Skip to content

REGR: fix calling numpy bitwise ufunc with Index objects #48149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

@jorisvandenbossche jorisvandenbossche added Regression Functionality that used to work in a prior pandas version Index Related to the Index class or subclasses ufuncs __array_ufunc__ and __array_function__ labels Aug 19, 2022
@jorisvandenbossche jorisvandenbossche added this to the 1.4.4 milestone Aug 19, 2022
@@ -16,6 +16,7 @@ Fixed regressions
~~~~~~~~~~~~~~~~~
- Fixed regression in taking NULL :class:`objects` from a :class:`DataFrame` causing a segmentation violation. These NULL values are created by :meth:`numpy.empty_like` (:issue:`46848`)
- Fixed regression in :func:`concat` materializing :class:`Index` during sorting even if :class:`Index` was already sorted (:issue:`47501`)
- Fixed regression in calling bitwise numpy ufuncs (for example, ``np.bitwise_and``) on Index objects (:issue:`46769`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Fixed regression in calling bitwise numpy ufuncs (for example, ``np.bitwise_and``) on Index objects (:issue:`46769`)
- Fixed regression in calling bitwise numpy ufuncs (for example, ``np.bitwise_and``) on :class:`Index` objects (:issue:`46769`)

Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jorisvandenbossche lgtm.

(whether the release note should be updated as suggested is subjective. My reasoning was to match the previous note)

@simonjayhawkins simonjayhawkins merged commit 901b02f into pandas-dev:main Aug 22, 2022
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 22, 2022
phofl pushed a commit that referenced this pull request Aug 22, 2022
…func with Index objects) (#48200)

Backport PR #48149: REGR: fix calling numpy bitwise ufunc with Index objects

Co-authored-by: Joris Van den Bossche <[email protected]>
@jorisvandenbossche jorisvandenbossche deleted the regr-index-bitwise-ufunc branch August 23, 2022 04:58
@jorisvandenbossche
Copy link
Member Author

(whether the release note should be updated as suggested is subjective. My reasoning was to match the previous note)

Yeah, in the meantime also some other entries have been added that didn't match that (although maybe mainly by me ;))
(in general, I find that using code formatting for every casual occurrence of DataFrame, Series, Index etc (not when specifying a specific method or referring to the class API docs) makes the text much more heavier to use)

noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Index Related to the Index class or subclasses Regression Functionality that used to work in a prior pandas version ufuncs __array_ufunc__ and __array_function__
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Pandas Index fails with bitwise ufuncs
2 participants