Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: Fixed inconsistent offset behavior for series #43784 #48129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Fixed inconsistent offset behavior for series #43784 #48129
Changes from 10 commits
bab1995
c62dde3
ee8752f
ea1db06
e91a1d8
4179d58
c43f2be
d79646b
0fcf0fd
21ed3c4
ff0bd57
71ef3d2
b9a5479
7672f40
073b187
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you undo this reordering?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this only is needed for
DateOffset
exactly and not its subclasses?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. Almost all of the subclasses of
DateOffset
deal with units larger than an hour, so they would not be affected. The only ones that could be realistically affected by this would beBusinessHour
andCustomBusinessHour
. However, due to the variable nature of the time differences in those classes (eg. adding 1 hour to the very end of a Friday actually ends up adding over 2 whole days to the start of Monday) I think they should not be affected by this change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this will be robust to users subclassing and defining their own
DateOffset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't thinking about user-created subclasses in my original response, rather I was thinking of the predefined subclasses like
YearEnd
. I have it specifically forDateOffset
and not its subclasses because this change relies on_use_relativedelta
, which signifies offsets in units smaller than a day inDateOffset
.DateOffset
's subclasses have it always set to a defaultFalse
, which I absolutely do not want this change to act on. Do you think there is a better way to do this?