Skip to content

TST: Check index when grouping all columns of empty DF (#32464) #48067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

YagoGG
Copy link
Contributor

@YagoGG YagoGG commented Aug 13, 2022

@YagoGG YagoGG force-pushed the tst/32464 branch 2 times, most recently from 5501f05 to acbf742 Compare August 13, 2022 01:09
@YagoGG
Copy link
Contributor Author

YagoGG commented Aug 13, 2022

Giving @rhshadrach attribution for the code as the test is basically his suggestion over #44046.

Let me know if any changes are needed. Thanks!

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@YagoGG
Copy link
Contributor Author

YagoGG commented Aug 14, 2022

Rebased with the latest main, as it looks that the build has been fixed now.

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added the Testing pandas testing functions or related to the test suite label Aug 15, 2022
@rhshadrach rhshadrach added this to the 1.5 milestone Aug 15, 2022
@mroeschke mroeschke merged commit c70f9b9 into pandas-dev:main Aug 15, 2022
@mroeschke
Copy link
Member

Thanks @YagoGG

@YagoGG YagoGG deleted the tst/32464 branch August 20, 2022 12:55
YYYasin19 pushed a commit to YYYasin19/pandas that referenced this pull request Aug 23, 2022
) (pandas-dev#48067)

TST: Check MultiIndex when grouping by all columns of an empty DF (pandas-dev#32464)

Co-authored-by: Richard Shadrach
    <[email protected]>

Co-authored-by: Richard Shadrach <[email protected]>
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
) (pandas-dev#48067)

TST: Check MultiIndex when grouping by all columns of an empty DF (pandas-dev#32464)

Co-authored-by: Richard Shadrach
    <[email protected]>

Co-authored-by: Richard Shadrach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Groupby MultiIndex Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grouping by all columns of an empty DataFrame should produce MultiIndex, but doesn't
3 participants