fixed docstring error with pandas.Series.plot.area:Unknown parameter: {'stacked'} #48063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuabello2550
changed the title
|
Hi, I don't believe the changes I have made, contributed to the errors in the checks. Could you please clarify? |
There are some related test failures: https://github.com/pandas-dev/pandas/runs/7811767621?check_suite_focus=true |
…joshuabello2550/pandas-bello into fix-PR02-issues-in-docstrings-2
|
Hi, I have tried to reproduce the test cases that are failing locally but could not. How can I go about debugging these errors? |
|
The issues look unrelated to this PR. Could you merge in main once more? |
phofl
approved these changes
Aug 26, 2022
|
thx @joshuabello2550 |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you run python
./scripts/validate_docstrings.py --errors=PR02, one of the errors is/home/pandas/pandas/plotting/_core.py:1470:PR02:pandas.Series.plot.area:Unknown parameters {'stacked'}The error I believe is because "stacked" is declared in the docstring, but is not a parameter within the function. Even though stacked is only passed in when setting stacked to False, it should still be defined in the function parameter.