DOC: add source link to properties #48054
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds reasonable. Could you show a before/after example of a docstring that is positively impacted? |
|
Stuff like Docs rendered in this PR have the link to Github source code as all methods and functions already have.
The link for this specific example points here. |
|
Thanks @martinfleis |
YYYasin19
pushed a commit
to YYYasin19/pandas
that referenced
this pull request
Aug 23, 2022
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of
linkcode_resolveis unable to handle properties and ignore them. Hence there are no links to the source code for properties unlike for everything else. This add support to properties I did in geopandas/geopandas#2526 (comment) which is based on pandas code, so I thought it is worth contributing the enhancement back.