REGR: groupby sum causing overflow for int8 #48044
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the regression from #48018
BUT: Handling this on the cython level like this is really ugly... and will blow up our wheel size if we introduce this everywhere, but I could not find a way to restrict the compile combinations.
If there is no better way of handling this on the cython level I would propose casting values to int64/uint64 before calling the group_sum function. This would introduce an unnecessary cast and reduce performance, hence why I was looking for a solution on the cython level.
cc @jorisvandenbossche cc @mroeschke