Skip to content

REGR: groupby sum causing overflow for int8 #48044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 11, 2022

This fixes the regression from #48018

BUT: Handling this on the cython level like this is really ugly... and will blow up our wheel size if we introduce this everywhere, but I could not find a way to restrict the compile combinations.

If there is no better way of handling this on the cython level I would propose casting values to int64/uint64 before calling the group_sum function. This would introduce an unnecessary cast and reduce performance, hence why I was looking for a solution on the cython level.

cc @jorisvandenbossche cc @mroeschke

@phofl phofl marked this pull request as draft August 11, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant