DEPR fixup warning message of MultiIndex.lexsort_depth deprecation #48025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
added
Warnings
mroeschke
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
LGTM. May be worth backporting to 1.4.4. since this corrects a deprecation message cc @simonjayhawkins
|
Thanks - TBH I doubt anyone's using this method anyway (searches I did for this in code only brought up the pandas test suite). Unless we've previously been strict about backporting warning messages, I'd suggest not bothering with this one |
YYYasin19
pushed a commit
to YYYasin19/pandas
that referenced
this pull request
Aug 23, 2022
…andas-dev#48025) fixup warning message of MultiIndex.lexsort_depth deprecation
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
…andas-dev#48025) fixup warning message of MultiIndex.lexsort_depth deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref https://github.com/pandas-dev/pandas/pull/38701/files#r942749562