Doc/categorical okexcept #47980
Closed
Doc/categorical okexcept #47980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the addition in the text it‘s unclear, what s.sort_values(inplace=True) should demonstrate. Show some meaningful output now. Also, when using astype to contrast ordered/unordered behavior, I think it‘s clearer to use the existing, unordered Series than to create a new one.
Without the addition in the text it‘s unclear, what s.sort_values(inplace=True) should demonstrate. Show some meaningful output now. Also, when using astype to contrast ordered/unordered behavior, I think it‘s clearer to use the existing, unordered Series than to create a new one. Use :okexept: directive as requested by mroeschke.
phofl
reviewed
Aug 5, 2022
| s = pd.Series(["a", "b", "c", "a"]).astype(CategoricalDtype(ordered=True)) | ||
| s.sort_values(inplace=True) | ||
| s | ||
| s.sort_values(ascending=False) |
There was a problem hiding this comment.
This does not sort inplace, e.g. s is not updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a variant of #47846 using the
:okexcept:directive instead oftry/exceptas requested by mroeschke.