Skip to content

DEPS: Update cython #47979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 8, 2022
Merged

DEPS: Update cython #47979

merged 5 commits into from
Aug 8, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 5, 2022 •
edited by lithomas1
Loading

@phofl phofl marked this pull request as draft August 5, 2022 13:10
@phofl phofl marked this pull request as ready for review August 5, 2022 15:01
@simonjayhawkins simonjayhawkins added the Build Library building on various platforms label Aug 5, 2022
@simonjayhawkins
Copy link
Member

Thanks @phofl

we also want to add a release note (see 1.4.3, moreless copy and paste that one). Cython is a dev only dependency so I'll milestone as 1.4.4 for now.

we should probably also add the test from #47097

@simonjayhawkins simonjayhawkins added this to the 1.4.4 milestone Aug 5, 2022
@simonjayhawkins simonjayhawkins added the Dependencies Required and optional dependencies label Aug 5, 2022
@simonjayhawkins
Copy link
Member

all the ci files and the setup.py also need updating

@simonjayhawkins
Copy link
Member

Thinking some more (after #47097 (comment)) I think ok to also add a release note for the regression fix too.

@simonjayhawkins simonjayhawkins mentioned this pull request Aug 5, 2022
Closed
4 tasks
@phofl
Copy link
Member Author

phofl commented Aug 5, 2022 •
edited
Loading

Changed the other versions (forgot about them earlier) and added the test

lmk if there is a better place for this test

@simonjayhawkins
Copy link
Member

Thanks @phofl . Let's give others chance to comment before we merge as I only opened the issue this morning.

lithomas1
lithomas1 requested changes Aug 6, 2022
View reviewed changes
Copy link
Member

@lithomas1 lithomas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Can you upgrade pyproject.toml too?
LGTM otherwise.

@lithomas1
Copy link
Member

BTW, I've edited the description to not close the two issues, since we still need MacPython/pandas-wheels#188 as well.

@zlspgz
Copy link

zlspgz commented Aug 6, 2022 via email

@phofl
Copy link
Member Author

phofl commented Aug 6, 2022

Updated pyproject.toml too.

simonjayhawkins
simonjayhawkins approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@simonjayhawkins simonjayhawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phofl will merge later today if no objections

@simonjayhawkins simonjayhawkins merged commit 8cb64ab into pandas-dev:main Aug 8, 2022
@lumberbot-app

This comment was marked as resolved.

Sign in to view
simonjayhawkins added a commit to simonjayhawkins/pandas that referenced this pull request Aug 8, 2022
@simonjayhawkins
Backport PR pandas-dev#47979: DEPS: Update cython
7c3ceb5
@simonjayhawkins simonjayhawkins mentioned this pull request Aug 8, 2022
Merged
phofl pushed a commit that referenced this pull request Aug 8, 2022
@simonjayhawkins
Backport PR #47979 on branch 1.4.x (DEPS: Update cython) (#48009)
05ae867 
* Backport PR #47979: DEPS: Update cython

* missed one
@phofl phofl deleted the 47978 branch August 8, 2022 21:29
@jorisvandenbossche jorisvandenbossche mentioned this pull request Aug 12, 2022
Closed
3 tasks
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@phofl @noatamir
DEPS: Update cython (pandas-dev#47979)
3648116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonjayhawkins simonjayhawkins simonjayhawkins approved these changes

@lithomas1 lithomas1 lithomas1 approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms Dependencies Required and optional dependencies
Projects
None yet
Milestone
1.4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@phofl @simonjayhawkins @lithomas1 @zlspgz