REF: Move Series logic from Index._get_values_for_loc #47975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
jbrockmendel
force-pushed
the
ref-get_values_for_loc
branch
from
a925651 to
0af361b
Compare
mroeschke
reviewed
Oct 24, 2022
| @@ -1062,7 +1063,24 @@ def _get_value(self, label, takeable: bool = False): | |||
|
|
|||
| # Similar to Index.get_value, but we do not fall back to positional | |||
| loc = self.index.get_loc(label) | |||
| return self.index._get_values_for_loc(self, loc, label) | |||
|
|
|||
| if is_integer(loc): | |||
There was a problem hiding this comment.
So since this PR has been opened code is no longer moved from Index._get_values_for_loc?
There was a problem hiding this comment.
get_values_for_loc can be removed after this. at the time this PR was opened there was another (deprecated) usage
mroeschke
approved these changes
Oct 24, 2022
|
Thanks @jbrockmendel |
noatamir
pushed a commit
to noatamir/pandas
that referenced
this pull request
Nov 9, 2022
* REF: Move Series logic from Index._get_values_for_loc * try again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaner abstraction.