Skip to content

ENH: Add dtype param for pandas.Series.str.get_dummies #47958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

JeffersonQin
Copy link

Copy link
Member

@phofl phofl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No real opionion on this, but please always add tests

@jreback
Copy link
Contributor

jreback commented Aug 4, 2022

the api should match pd.get_dummies here

@mroeschke mroeschke added Enhancement Strings String extension data type and string data labels Aug 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Sep 8, 2022
@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Stale Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Allow different dtype in pandas.Series.str.get_dummies
4 participants