Skip to content

DOC: Fix missing s3 file in read xml doc example #47951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 3, 2022

This returns now

              journal-id              journal-title       issn  publisher
0  Cardiovasc Ultrasound  Cardiovascular Ultrasound  1476-7120        NaN

Fixes ci for now, happy to open another issue, if someone thinks we could use a better file

@phofl phofl added Docs Regression Functionality that used to work in a prior pandas version labels Aug 3, 2022
@phofl phofl added this to the 1.4.4 milestone Aug 3, 2022
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @phofl. Looks good to me as a permanent solution.

@datapythonista datapythonista merged commit 8b5dfa2 into pandas-dev:main Aug 4, 2022
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Aug 4, 2022
simonjayhawkins pushed a commit that referenced this pull request Aug 4, 2022
…xml doc example) (#47957)

Backport PR #47951: DOC: Fix missing s3 file in read xml doc example

Co-authored-by: Patrick Hoefler <[email protected]>
@phofl phofl deleted the 47945 branch August 4, 2022 13:52
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI/DOC: referenced s3 file was removed
2 participants