Skip to content

BUG: avoid relying on external packaging package in interchange protocol #47939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

I noticed this by accident, and we have a vendored version of packaging that we otherwise use internally.

(this might be a good case to add a code check for? cc @MarcoGorelli)

@jorisvandenbossche jorisvandenbossche added Bug Dependencies Required and optional dependencies labels Aug 3, 2022
@jorisvandenbossche jorisvandenbossche added this to the 1.5 milestone Aug 3, 2022
@simonjayhawkins
Copy link
Member

Thanks @jorisvandenbossche

(this might be a good case to add a code check for? cc @MarcoGorelli)

can always raise an issue for this.

we have a vendored version of packaging that we otherwise use internally.

xref #41207, do we have an open issue to potentially remove this in the future?

@MarcoGorelli
Copy link
Member

@jorisvandenbossche which are the packages which pandas vendors? Just version and clipboard?

@jorisvandenbossche
Copy link
Member Author

I am not directly aware of others (except for some C code). And probably packaging.version is the main relevant one, as clipboard / pyperclip might not be that common to use in normal code outside of the clipboard IO code

noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants