Skip to content

Revert "CI: Pin cython on 32bit build" #47898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Conversation

lithomas1
Copy link
Member

Reverts #47889

Let's see if cython 0.29.32 fixes this

@lithomas1 lithomas1 added Build Library building on various platforms CI Continuous Integration labels Jul 29, 2022
@lithomas1
Copy link
Member Author

Looks like the conda packages for 0.29.32 might not be uploaded fully yet, so jobs just need to be retrigerred later on in the day.

@mroeschke
Copy link
Member

FWIW cython=0.29.30 is pinned in all the other ci/deps/ yaml files except actions-310-numpydev.yaml which is supposed to test cython master.

So actually pinning in the 32 bit build makes it consistent with the rest of the builds which would be a good thing.

Or should cython>=0.29.30 be specified here and the other builds instead?

@lithomas1
Copy link
Member Author

I don't think we should pin Cython, otherwise we could have some surprising failures when we bump Cython for the new Python version.

@mroeschke mroeschke added this to the 1.5 milestone Aug 1, 2022
@lithomas1 lithomas1 merged commit 91d4cc5 into main Aug 1, 2022
@lithomas1 lithomas1 deleted the revert-47889-ci/32bit/cython branch August 1, 2022 23:09
@MarcoGorelli
Copy link
Member

Hey @lithomas1 - could you please drop me an email at @ protonmail . com ? Or add me on LinkedIn and contact me there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants