Skip to content

TYP: Column.null_count is a Python int #47804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2022
Merged

TYP: Column.null_count is a Python int #47804

merged 1 commit into from
Jul 21, 2022

Conversation

mroeschke
Copy link
Member

No whatsnew needed since the exchange protocol will be new in 1.5

@mroeschke mroeschke added the Interchange Dataframe Interchange Protocol label Jul 20, 2022
@mroeschke mroeschke added this to the 1.5 milestone Jul 20, 2022
twoertwein
twoertwein approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type annotations look good to me (cannot comment on the implementation change).

@twoertwein twoertwein added the Typing type annotations, mypy/pyright type checking label Jul 21, 2022
@mroeschke mroeschke merged commit 060ce49 into pandas-dev:main Jul 21, 2022
@mroeschke mroeschke deleted the xch/null_int branch July 21, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

Assignees
No one assigned
Labels
Interchange Dataframe Interchange Protocol Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

BUG: Interchange Column.null_count is a NumPy scalar, not a builtin int
2 participants
@mroeschke @twoertwein