Skip to content

TST: Test series construct of dtype timedelta64 #35465 #47801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ntachukwu
Copy link
Contributor

Tests for repr of Series with dtype timedelta64
@pep8speaks
Copy link

pep8speaks commented Jul 20, 2022

Hello @Th3nn3ss! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-07-27 12:21:13 UTC

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't a repr issue. For this unit test we want to compare a Series constructed in an alternative way but should be equivalent

result = ...
expected = Series(pd.to_timedelta([...]))
tm.assert_series_equal(result, expected)

so therefore these tests should also go in a file that tests constructing Series

@ntachukwu
Copy link
Contributor Author

Thanks. I wasn't really sure where to put the tests. I will make changes and update the PR tomorrow. 😄

@mroeschke
Copy link
Member

Thanks. I wasn't really sure where to put the tests. I will make changes and update the PR tomorrow. 😄

Maybe pandas/tests/series/test_constructors.py

@ntachukwu ntachukwu changed the title TST: Test repr for dtype timedelta64 series #35465 TST: Test series construct of dtype timedelta64 #35465 Jul 21, 2022
@ntachukwu ntachukwu requested a review from mroeschke July 21, 2022 11:48
@mroeschke
Copy link
Member

Appears some test build are still failing

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Timedelta Timedelta data type labels Jul 22, 2022
@ntachukwu
Copy link
Contributor Author

Hi @mroeschke How do I fix the failing build tests?

@mroeschke
Copy link
Member

Try merging in main one more time. We had a flaky test that was affecting all builds last week

@mroeschke mroeschke added this to the 1.5 milestone Jul 27, 2022
@mroeschke mroeschke merged commit 9a2276f into pandas-dev:main Jul 27, 2022
@mroeschke
Copy link
Member

Thanks @Th3nn3ss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Timedelta Timedelta data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Inconsistent initialization of timedelta64 between Series vs numpy & pd.TimeDelta
3 participants