-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Test series construct of dtype timedelta64 #35465 #47801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Test series construct of dtype timedelta64 #35465 #47801
Conversation
Tests for repr of Series with dtype timedelta64
Hello @Th3nn3ss! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-07-27 12:21:13 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't a repr issue. For this unit test we want to compare a Series constructed in an alternative way but should be equivalent
result = ...
expected = Series(pd.to_timedelta([...]))
tm.assert_series_equal(result, expected)
so therefore these tests should also go in a file that tests constructing Series
Thanks. I wasn't really sure where to put the tests. I will make changes and update the PR tomorrow. 😄 |
Maybe |
Tests for Series constructs with dtype timedelta64
Appears some test build are still failing |
Hi @mroeschke How do I fix the failing build tests? |
Try merging in main one more time. We had a flaky test that was affecting all builds last week |
Thanks @Th3nn3ss |
timedelta64
between Series vs numpy & pd.TimeDelta #35465