Skip to content

DOC: Fix versionadded for callable in on_bad_lines #47792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 20, 2022
Merged

DOC: Fix versionadded for callable in on_bad_lines #47792

merged 1 commit into from
Jul 20, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Jul 19, 2022

@phofl phofl added Docs IO CSV read_csv, to_csv labels Jul 19, 2022
@phofl phofl added this to the 1.4.4 milestone Jul 19, 2022
mroeschke
mroeschke reviewed Jul 20, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this render now?

@phofl
Copy link
Member Author

phofl commented Jul 20, 2022

grafik

Seems correct now

mroeschke
mroeschke approved these changes Jul 20, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@mroeschke mroeschke merged commit f7e0e68 into pandas-dev:main Jul 20, 2022
@lumberbot-app
Copy link

lumberbot-app bot commented Jul 20, 2022

Something went wrong ... Please have a look at my logs.

phofl added a commit to phofl/pandas that referenced this pull request Jul 20, 2022
@phofl
DOC: Fix versionadded for callable in on_bad_lines (pandas-dev#47792)
b31b8f8
@phofl
Copy link
Member Author

phofl commented Jul 20, 2022

#47795

@phofl phofl deleted the 47788 branch July 20, 2022 00:39
simonjayhawkins pushed a commit that referenced this pull request Jul 20, 2022
@phofl
Backport PR #47792 on branch 1.4.x (DOC: Fix versionadded for callabl…
49ab26c 
…e in on_bad_lines) (#47795)

DOC: Fix versionadded for callable in on_bad_lines (#47792)
@simonjayhawkins simonjayhawkins mentioned this pull request Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Docs IO CSV read_csv, to_csv
Projects
None yet
Milestone
1.4.4
Development

Successfully merging this pull request may close these issues.

DOC: on_bad_lines parameter on read_csv is wrongly labeled for the version 1.3.0 when it should be 1.4.0
2 participants
@phofl @mroeschke