-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BLD: windows builds failing in pandas.json (#4764) #4778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
now compiles ok, but (and last test causes it to crash python in both cases)
|
You might be able to create a virtual windows box with vagrant (maybe just do 32-bit as its easier to compile). http://kamalim.github.io/blogs/how-to-create-you-own-vagrant-base-boxes/ This works really well on linux type boxes as you can then get the exact configuration for say a travis build (e.g. I just debugged a python 3.2 with numpy 1.6.1 problem!) |
Ick, ok I'll try to get my hands on a windows setup and take a closer look. Thanks! |
OK just tested on a windows 7, 32-bit setup and was unable to reproduce the failures / crashing. Worked for me with both mingw (with an additional build fix, see commit) and visual express 2010.
In the VS2010 setup I did see a segmentation fault in the unrelated cparser tests but I suspect that's due to mixing MinGW compiled Python(x,y) / Cython with VSC compiled pandas. @jreback could you give more info on the test failures / errors, and the setup you are encountering them on, is it numpy 1.6? I'll see if I can reproduce on 64 bit... |
numpy 1.7 |
FYI my laptop decided to give up the ghost this morning so this is going to delay me a bit more :-( To get the windows build fixed right now, either the json datetime changes could be factored out or the two commits above could be applied. I assume the tests will still fail but at least things will build. I'll try and get these test issues sorted once I get myself back up and running. |
@jreback FWIW (and as a note for others who go through windows pain) I tested a 32-bit install on Win7 64-bit box, with enthought canopy (32-bit) as a base. My first attempt was with VS2010 (I couldn't find 2008). Same deal as before, JSON tests pass for me but the cparser tests crash out. Proceeding with the assumption that this is because of mixing compilers (VS2008 compiled Python, numpy etc and VS2010 compiled pandas+cython) I set out to get my hands on VS2008. Found VS2008 thanks to stackoverflow. When compiled all tests run ok, no python crashing, hurrah! I did see a few minor test failures though. Out of interest what is your setup on windows: enthought, compiler etc? I'm still a bit suspicious of the tests failing so spectacularly. |
Test failures for ref (are these known windows issues?):
|
I have vs2010 so some of the parser tests crash for me as well |
some of those I fixed today |
Can you merge in the mingw build fix aswell? Then this PR can be closed. |
sure |
whoops yeah will do, sry |
Should be good to go now |
BLD: windows builds failing in pandas.json (#4764)
can u repost the test failures that u see now after rebuilding? (I did fix some of them earlier today) |
perfect I know what most of these are except for the plotting ones |
No description provided.