Specify that both by and level should not be specified in groupby - GH40378
#47778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Jul 18, 2022
|
Thanks @GivyBoy |
rhshadrach
reviewed
Jul 18, 2022
| @@ -345,6 +345,17 @@ Index level names may be supplied as keys. | |||
|
|
|||
| More on the ``sum`` function and aggregation later. | |||
|
|
|||
| When using ``.groupby()`` on a DatFrame with a MultiIndex, do not specify both ``by`` and ``level``. | |||
| The argument validation should be done in ``.groupby()``, using the name of the specific index. | |||
There was a problem hiding this comment.
I think the last line here is coming from #40378 (comment). I was stating that the pandas code should validate the arguments, I don't understand what this sentence means in the documentation.
Also, I think this should be specified in the API docs for Series/DataFrame.groupby too.
There was a problem hiding this comment.
Hi! Thanks for the comments. I have submitted a new pull request (#47825). Feel free to look at the code. Thanks!
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.