STYLE add future annotations where possible #47769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MarcoGorelli
commented
Jul 17, 2022
MarcoGorelli
commented
- closes STYLE add check for future annotations #41901 (Replace xxxx with the Github issue number)
- All code checks passed.
MarcoGorelli
commented
Jul 17, 2022
Comment on lines
-97
to
-98
| - repo: local | ||
| hooks: |
There was a problem hiding this comment.
not relevant to this PR, but there's no need to keep repeating repo: local, so removing these extra ones while I'm here
MarcoGorelli
commented
Jul 17, 2022
| name: import annotations from __future__ | ||
| entry: 'from __future__ import annotations' | ||
| language: pygrep | ||
| args: [--negate] |
There was a problem hiding this comment.
negate checks that the pattern in entry is always present (as opposed to checking it's absent)
MarcoGorelli
force-pushed
the
future-annotations
branch
from
5153a39 to
826716f
Compare
twoertwein
reviewed
Jul 17, 2022
MarcoGorelli
force-pushed
the
future-annotations
branch
from
826716f to
c1182ef
Compare
twoertwein
approved these changes
Jul 17, 2022
mroeschke
approved these changes
Jul 18, 2022
|
Thanks @MarcoGorelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.