Skip to content

TYP: Appender also works with properties #47768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2022
Merged

TYP: Appender also works with properties #47768

merged 1 commit into from
Jul 18, 2022

Conversation

twoertwein
Copy link
Member

Technically, Appender works with literally any object as all of them have __doc__.

This change helps pyright in this case

pandas/pandas/core/series.py

Line 738 in bdd9314

# error: Decorated property not supported

Mypy still needs the ignore because it doesn't support decorating a property.

@twoertwein twoertwein added the Typing type annotations, mypy/pyright type checking label Jul 17, 2022
@MarcoGorelli
Copy link
Member

Hey

Mypy still needs the ignore because it doesn't support decorating a property.

Not sure I follow - which property is being decorated?

@twoertwein
Copy link
Member Author

Not sure I follow - which property is being decorated?

This property

pandas/pandas/core/series.py

Line 740 in bdd9314

@property

MarcoGorelli
MarcoGorelli approved these changes Jul 17, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This property

ah apologies, I'd accidentally navigated to a different part of series.py and couldn't tell what you were referring to

Looks good to me

@MarcoGorelli MarcoGorelli added this to the 1.5 milestone Jul 17, 2022
@mroeschke mroeschke merged commit 0a26cdd into pandas-dev:main Jul 18, 2022
@mroeschke
Copy link
Member

Thanks @twoertwein

@twoertwein twoertwein deleted the appender branch September 10, 2022 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@twoertwein @MarcoGorelli @mroeschke